Skip to content

Conversation

@Qetesh
Copy link
Contributor

@Qetesh Qetesh commented Oct 27, 2025

No description provided.

@Subhra264
Copy link
Collaborator

Hi @Qetesh , I think generally the chrome view port width is bigger than the viewport height on most laptops/monitors. I guess you wanted to mean pdf print page width and height? I added new env variables in the last pr, to add custom values for pdf page width and height (default values are given below, unit is inches) -

ZO_PDF_PAPER_WIDTH = 8.5
ZO_PDF_PAPER_HEIGHT = 11.0

@Qetesh
Copy link
Contributor Author

Qetesh commented Oct 30, 2025

Thank you for the explanation!

My change was only to correct the swapped width and height naming to keep them consistent.

@Subhra264
Copy link
Collaborator

Hey @Qetesh , sorry I think I missed that part of your pr. Yeah, you are right. The width and height of the headless chromium is swapped. However, I think we don't need to swap the default values of width and height in the ENV variables.

There is a problem in the main branch currently where the browser rendering for print mode is kinda buggy (the dashboard panels overlap each other in the reports). As we checked, the chrome width 1024 works the best with almost all kind of panels in reports - the panels don't overlap. Hence, I am thinking of making 1024 the default width of chromium. If you don't mind, I will update the default width to 1024 and merge your pr.

@Qetesh
Copy link
Contributor Author

Qetesh commented Nov 7, 2025

Hey @Subhra264 ,I completely agree with your approach.

For my own setup, I use 1920×1500 and switched the ReportType to PNG — it displays better in terms of width and fits nicely with my macOS Mail client.

@Subhra264
Copy link
Collaborator

Closing this, in favour of #23. Thank you for the contribution!

@Subhra264 Subhra264 closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants